-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 74827 public route #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature_74827_public_route
This update includes the renaming of `AssetFilePublicRouteAdmDto` to `AssetFileRouteAdmCreateDto`. It also includes the creation of `AssetFileRouteAdmDetailDecorator` and `AssetFileRouteUrlHandler`. Additionally, the newly introduced `assetFileRouteGenerator` is used for serializing the public URL of an `AssetFileRoute` in various DTOs. This refactoring improves the naming consistency and enhances code readability and maintainability.
The code updates apply the decorator pattern to the response details of different entities including DocumentFile, AudioFile, and ImageFile. The classes ImageController, AudioController, and DocumentController now use the `AssetFileRouteAdmDetailDecorator` class to handle response details. In addition, the 'makePublic' method has been updated in each controller to ensure better consistency and conformity to the used design pattern.
Deleted `AudioLinksHandler`, `ImageLinksHandler`, and `ImageLinksManyTagsHandler` and created a unified `LinksHandler` for processing audio and image link serialization. Image animation support was added in `ImageUrlFactory` and `ImageController`. To allow different configurations for views, introduced the `ApiViewType` enum that replaces hardcoded constant strings.
A default crop dimension is now set in the `RequestedCropDto` class, with a width of 450 and height of 300. In the controller classes, logic for handling images has been refactored and includes better support for ‘not found’ responses. Unnecessary data fixtures relating to audio files have been removed.
The Dockerfile and the continuous integration configuration have been updated to use a new version of the PHP image: 3.0.0-php83-cli-vipsffmpeg. Also, unnecessary annotations usage has been removed from the test bootstrap script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.