Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 74827 public route #70

Merged
merged 31 commits into from
Jan 9, 2024
Merged

Conversation

TomasHermanek
Copy link
Contributor

No description provided.

This update includes the renaming of `AssetFilePublicRouteAdmDto` to `AssetFileRouteAdmCreateDto`. It also includes the creation of `AssetFileRouteAdmDetailDecorator` and `AssetFileRouteUrlHandler`. Additionally, the newly introduced `assetFileRouteGenerator` is used for serializing the public URL of an `AssetFileRoute` in various DTOs. This refactoring improves the naming consistency and enhances code readability and maintainability.
The code updates apply the decorator pattern to the response details of different entities including DocumentFile, AudioFile, and ImageFile. The classes ImageController, AudioController, and DocumentController now use the `AssetFileRouteAdmDetailDecorator` class to handle response details. In addition, the 'makePublic' method has been updated in each controller to ensure better consistency and conformity to the used design pattern.
Deleted `AudioLinksHandler`, `ImageLinksHandler`, and `ImageLinksManyTagsHandler` and created a unified `LinksHandler` for processing audio and image link serialization. Image animation support was added in `ImageUrlFactory` and `ImageController`. To allow different configurations for views, introduced the `ApiViewType` enum that replaces hardcoded constant strings.
A default crop dimension is now set in the `RequestedCropDto` class, with a width of 450 and height of 300. In the controller classes, logic for handling images has been refactored and includes better support for ‘not found’ responses. Unnecessary data fixtures relating to audio files have been removed.
The Dockerfile and the continuous integration configuration have been updated to use a new version of the PHP image: 3.0.0-php83-cli-vipsffmpeg. Also, unnecessary annotations usage has been removed from the test bootstrap script.
@TomasHermanek TomasHermanek merged commit 16904df into main Jan 9, 2024
1 check passed
@TomasHermanek TomasHermanek deleted the feature_74827_public_route branch January 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant